dlmarion opened a new issue, #3668:
URL: https://github.com/apache/accumulo/issues/3668

   The Tablet metadata is updated in `DatafileManager.importMapFiles` 
[here](https://github.com/apache/accumulo/blob/2.1/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L265)
 outside of the tablet lock. Then, the `datafileSizes` map is modified inside 
of the Tablet lock 
[here](https://github.com/apache/accumulo/blob/2.1/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L274).
 
[`Tablet.compareTabletInfo`](https://github.com/apache/accumulo/blob/2.1/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java#L1141)
 is called from a thread in the TabletServer periodically. Does updating the 
tablet metadata outside of the tablet lock in `importMapFiles` make it more 
likely that the `compareTabletInfo` check would see a file in the tablet 
metadata but *not* in datafileSizes? It seems to me that if `compareTabletInfo` 
ran between Tablet line 265 and line 269, then it would report missing files 
that may 
 not be missing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to