DomGarguilo commented on issue #3486:
URL: https://github.com/apache/accumulo/issues/3486#issuecomment-1659058057

   I am working on adding these tests and ran into something that I am a bit 
confused about and was hoping someone could help clear up for me.
   
   The impl of `isPropertySet` in `DefaultConfiguration` just returns false:
   
https://github.com/apache/accumulo/blob/4ec6dd2054d6a588dfc5a9a5f139d32799c90e83/core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java#L63-L66
   It is not evident to me why this is the case and seems odd that it returns 
false even when the property exists within the `Map<String,String>` of 
properties. This affects the behavior of other implementations as well, for 
example `SiteConfiguration.isPropertySet` which checks its `parent` config 
which is a `DefaultConfiguration` resulting in similar behavior as describes 
above in certain scenarios:
   
https://github.com/apache/accumulo/blob/4ec6dd2054d6a588dfc5a9a5f139d32799c90e83/core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java#L248-L251
   
   Why is `DefaultConfiguration.isPropertySet` implemented this way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to