ivakegg commented on code in PR #3677:
URL: https://github.com/apache/accumulo/pull/3677#discussion_r1283439240
##########
server/base/src/main/java/org/apache/accumulo/server/conf/TableConfiguration.java:
##########
@@ -178,6 +178,14 @@ private static CompactionDispatcher
createCompactionDispatcher(AccumuloConfigura
CompactionDispatcher newDispatcher =
Property.createTableInstanceFromPropertyName(conf,
Property.TABLE_COMPACTION_DISPATCHER, CompactionDispatcher.class,
null);
+ if (newDispatcher == null) {
+ // return early to prevent NPE
+ log.error(
Review Comment:
Does it need to be an error however? Could it be a debug or info?
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java:
##########
@@ -1473,6 +1473,13 @@ public CompactionServiceId
getConfiguredService(CompactionKind kind) {
try {
var dispatcher =
tablet.getTableConfiguration().getCompactionDispatcher();
+ if (dispatcher == null) {
+ log.error(
Review Comment:
debug or info ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
