keith-turner commented on code in PR #3681:
URL: https://github.com/apache/accumulo/pull/3681#discussion_r1290848998
##########
shell/src/main/java/org/apache/accumulo/shell/commands/GetTabletHostingGoalCommand.java:
##########
@@ -48,11 +48,11 @@ public String description() {
@Override
protected void doTableOp(Shell shellState, String tableName) throws
Exception {
- List<HostingGoalForTablet> tabletHostingGoal =
shellState.getAccumuloClient().tableOperations()
- .getTabletHostingGoal(tableName, range).collect(Collectors.toList());
+ List<TabletInformation> tabletInformationList =
shellState.getAccumuloClient().tableOperations()
+ .getTabletInformation(tableName, range).collect(Collectors.toList());
shellState.getWriter().println("TABLE: " + tableName);
shellState.getWriter().println("TABLET ID HOSTING GOAL");
- tabletHostingGoal.forEach(p -> shellState.getWriter()
+ tabletInformationList.forEach(p -> shellState.getWriter()
Review Comment:
May be able to do something like the following and avoid creating the list.
```suggestion
shellState.getAccumuloClient().tableOperations()
.getTabletInformation(tableName, range).forEach(p ->
shellState.getWriter()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]