DomGarguilo commented on code in PR #3684:
URL: https://github.com/apache/accumulo/pull/3684#discussion_r1292824138
##########
shell/src/main/java/org/apache/accumulo/shell/commands/MergeCommand.java:
##########
@@ -53,13 +53,9 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
size =
ConfigurationTypeHelper.getFixedMemoryAsBytes(cl.getOptionValue(sizeOpt.getOpt()));
}
if (startRow == null && endRow == null && size < 0 && !all) {
- shellState.getWriter().flush();
- String line = shellState.getReader()
- .readLine("Merge the entire table { " + tableName + " } into one
tablet (yes|no)? ");
- if (line == null) {
- return 0;
- }
- if (!line.equalsIgnoreCase("y") && !line.equalsIgnoreCase("yes")) {
+ if (!shellState
Review Comment:
Do we not want `force` to take affect here for this command? It would be a
change in behavior if added, but just curious.
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java:
##########
@@ -78,6 +79,8 @@ public int execute(final String fullCommand, final
CommandLine cl, final Shell s
NamespaceNotFoundException {
reader = shellState.getReader();
+ Boolean force = cl.hasOption(forceOpt);
Review Comment:
Could this be the primitive `boolean` instead of `Boolean`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
