ctubbsii opened a new pull request, #3691: URL: https://github.com/apache/accumulo/pull/3691
Fix the incorrect use of assert statements in test code when a JUnit assertTrue is the appropriate solution to resolve the error caught by the errorprone compiler. This issue was only seen on the 2.1 branch after bumping the version of errorprone to the same version as in the main branch. The issue still exists on the main branch, but for some reason, erorrprone doesn't flag on it in that branch. It was seen after creating 2.1.2-rc1, but is not important enough to warrant creating an rc2. If rc1 fails the vote, this can be included in rc2. This PR does not replace all assert statements, only those that were obviously incorrect, which was enough to make the errorprone check pass locally. This does not change assert statements in non-test code, and does not change them in the test-adjacent utility code, such as SlowOps and BatchWriterIterator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
