keith-turner commented on PR #3671: URL: https://github.com/apache/accumulo/pull/3671#issuecomment-1686977210
@ctubbsii all three try blocks currently can only throw RuntimeException. Two of the methods containing the try blocks throw IOException. So if I change the catch blocks to RuntimeException then its possible that someone in the future could call a method that throws IOException and it will compile but not be logged. Because of this I would prefer to leave the code as catching exception. Your suggestions makes sense for the case where the methods are not throwing checked exceptions already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
