ddanielr commented on code in PR #3738:
URL: https://github.com/apache/accumulo/pull/3738#discussion_r1330461208
##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -156,8 +159,9 @@ private void
removeCandidatesInUse(GarbageCollectionEnvironment gce,
dir = makeRelative(dir, 2);
- if (candidateMap.remove(dir) != null) {
- log.debug("Candidate was still in use: {}", dir);
+ GcCandidate gcTemp = candidateMap.remove(dir);
+ if (gcTemp != null) {
+ log.debug("Directory Candidate was still in use by dir ref: {}",
dir);
Review Comment:
Comments have been added regarding the intentional ignoring of the InUse Dir
candidates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
