ctubbsii commented on code in PR #22:
URL: https://github.com/apache/accumulo-access/pull/22#discussion_r1344739853
##########
src/main/java/org/apache/accumulo/access/AeNode.java:
##########
@@ -39,6 +39,21 @@ abstract class AeNode implements Comparable<AeNode> {
abstract int ordinal();
+ @Override
+ public boolean equals(Object o) {
+ if (o instanceof AeNode) {
+ return compareTo((AeNode) o) == 0;
+ }
+
+ return false;
Review Comment:
this can be written much more succinctly as:
```java
return o instanceof AeNode && compareTo((AeNode) o) == 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
