dlmarion commented on code in PR #3810:
URL: https://github.com/apache/accumulo/pull/3810#discussion_r1348004469
##########
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java:
##########
@@ -43,11 +43,11 @@
public class Authorizations implements Iterable<byte[]>, Serializable,
AuthorizationContainer {
private static final long serialVersionUID = 1L;
- private static final Set<ByteSequence> EMPTY_AUTH_SET =
Collections.emptySet();
- private static final List<byte[]> EMPTY_AUTH_LIST = Collections.emptyList();
+ private static final HashSet<ByteSequence> EMPTY_AUTH_SET = new HashSet<>();
+ private static final ArrayList<byte[]> EMPTY_AUTH_LIST = new ArrayList<>();
Review Comment:
So, it wasn't the static fields that were an issue. It was the instance
fields. But then we return the static fields in some cases. I may have
over-corrected on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
