keith-turner commented on code in PR #25:
URL: https://github.com/apache/accumulo-access/pull/25#discussion_r1358598682
##########
src/main/java/org/apache/accumulo/access/AccessEvaluator.java:
##########
@@ -24,8 +24,13 @@
* <p>
* Used to decide if an entity with one more sets of authorizations can access
zero or more access
* expression.
- *
* <p>
+ * <p>
+ * Note: For performance improvements, especially in cases where expressions
are expected to repeat,
+ * it's recommended to wrap this evaluator with an external caching mechanism,
such as Guava's
+ * cache, to leverage its extensive caching options.
Review Comment:
Could add a caveat to the caching suggestion.
```suggestion
* cache, to leverage its extensive caching options. Caching is only safe
under the assumption that for an AccessEvaluator instance that evaluating the
same expression multiple times will always yield the same result. When
considering caching, may need to mitigate any environmental factors that could
change this assumption.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
