cshannon commented on PR #3875:
URL: https://github.com/apache/accumulo/pull/3875#issuecomment-1773801956

   > @cshannon thanks for the feedback, it was very helpful in fixing the 
problem. I pushed 
[53cd856](https://github.com/apache/accumulo/commit/53cd8569c44aebc9a36028006970232df6125941)
 based on your feedback.. In that change only tablets that completely fall 
within the delete range are merged away. This is almost ready to take out of 
draft, need to to a bit of cleanup. MergeIT and DeleteRowsIT are passing now.
   
   Great, that is good that now the splits and files match so the tests pass 
and is equivalent. I took a quick peak at the changes and they look good and I 
can do a final review when it's ready and out of draft. I like the new methods 
added with `getReserveExtent` and `getMergeExtent` and I think that makes it 
easier to understand what is going on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to