ddanielr commented on PR #3877:
URL: https://github.com/apache/accumulo/pull/3877#issuecomment-1775409349
> Is it the case that a `one line reference to a different property` cannot
end in a period?
No, it ending with a period is a valid case.
If the description already ends with a period then it is never compared
against the `one line ref` regex.
The test checks for the existence of an ending period first. If that check
fails, the description is then checked against the `one line ref` regex.
If we don't want the `one line refs` ending with a period we could switch
the order of the checks.
```
+ boolean isOneLineRef = prop.getDescription().matches("^See \\{% jlink
-f [\\w\\.]* %\\}$");
+ if (!isOneLineRef) {
+ assertTrue(prop.getDescription().endsWith("."),
```
Comparing all the descriptions against the regex first doesn't impact the
test completion time as the test still completes in under a second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
