DomGarguilo commented on PR #27: URL: https://github.com/apache/accumulo-access/pull/27#issuecomment-1781729268
I ran the benchmark on 6bfcf86 Benchmark Mode Cnt Score Error Units AccessExpressionBenchmark.measureBytesParsing thrpt 12 8.956 ± 0.068 ops/us AccessExpressionBenchmark.measureEvaluation thrpt 12 13.218 ± 0.165 ops/us AccessExpressionBenchmark.measureEvaluationAndParsing thrpt 12 5.689 ± 0.051 ops/us AccessExpressionBenchmark.measureStringParsing thrpt 12 8.244 ± 0.151 ops/us I also ran the benchmark on but removed the helper functions from BytesUtil and just used inline logic with the constants for example from `!isQuoteOrSlash(expression[index])` back to `!(expression[index] == QUOTE || expression[index] == BACKSLASH)` with these results: Benchmark Mode Cnt Score Error Units AccessExpressionBenchmark.measureBytesParsing thrpt 12 8.683 ± 0.077 ops/us AccessExpressionBenchmark.measureEvaluation thrpt 12 13.058 ± 0.088 ops/us AccessExpressionBenchmark.measureEvaluationAndParsing thrpt 12 5.709 ± 0.036 ops/us AccessExpressionBenchmark.measureStringParsing thrpt 12 8.227 ± 0.063 ops/us Given these results im not sure that the BytesUtil imports are causing any overhead. I am not sure what is causing the difference in performance for Evaluation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
