cshannon commented on issue #3845: URL: https://github.com/apache/accumulo/issues/3845#issuecomment-1782753938
@keith-turner - I think your proposed changes make sense. I think adding checks to the verifyMergeConsistency() make the most sense as it can be shared in 2.1 and 3.1 and the purpose of the method is a verification before starting so it's the logical spot. As you said, in 2.1 it may be more redundant since the WALs are checked before but wouldn't hurt. It's definitely needed in 3.1 since those checks were removed when I removed chopped compactions. For testing, I agree, it may not be easy to test with an IT, we may just need some unit testing. I can start working on a PR for the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
