cshannon commented on code in PR #3903:
URL: https://github.com/apache/accumulo/pull/3903#discussion_r1376830487


##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -279,6 +280,12 @@ private boolean shouldReturnDueToLocation(final 
TabletMetadata tm,
             || (tm.getHostingGoal() == TabletHostingGoal.ONDEMAND && 
tm.getHostingRequested()))) {
           return true;
         }
+        // If the Tablet has walogs and operation id then need to return so
+        // TGW can bring online to process the logs
+        if (tm.getLogs().isEmpty() && tm.getOperationId() != null

Review Comment:
   @keith-turner - Oops, nice catch this is probably why the test i started to 
write didn't work as this logic was backwards. I can revisit the tests after 
you merge in your refactoring for #3904.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to