keith-turner commented on code in PR #3945:
URL: https://github.com/apache/accumulo/pull/3945#discussion_r1394367789
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactionDriver.java:
##########
@@ -137,45 +140,60 @@ public int updateAndCheckTablets(Manager manager, long
tid)
// ELASTICITY_TODO use existing compaction logging
- try (
- var tablets =
ample.readTablets().forTable(tableId).overlapping(startRow, endRow)
- .fetch(PREV_ROW, COMPACTED, FILES, SELECTED, ECOMP,
OPID).checkConsistency().build();
- var tabletsMutator = ample.conditionallyMutateTablets()) {
+ var fateStr = FateTxId.formatTid(tid);
+
+ Consumer<Ample.ConditionalResult> resultConsumer = result -> {
+ if (result.getStatus() == Status.REJECTED) {
+ log.debug("{} update for {} was rejected ", fateStr,
result.getExtent());
+ }
+ };
+
+ long t1 = System.currentTimeMillis();
- int complete = 0;
- int total = 0;
+ int complete = 0;
+ int total = 0;
+ int opidsSeen = 0;
+ int noFiles = 0;
+ int noneSelected = 0;
+ int alreadySelected = 0;
+ int otherSelected = 0;
+ int otherCompaction = 0;
+ int selected = 0;
- int selected = 0;
+ KeyExtent minSelected = null;
+ KeyExtent maxSelected = null;
- KeyExtent minSelected = null;
- KeyExtent maxSelected = null;
+ try (
+ var tablets =
ample.readTablets().forTable(tableId).overlapping(startRow, endRow)
+ .fetch(PREV_ROW, COMPACTED, FILES, SELECTED, ECOMP,
OPID).checkConsistency().build();
+ var tabletsMutator = ample.conditionallyMutateTablets(resultConsumer))
{
CompactionConfig config =
CompactionConfigStorage.getConfig(manager.getContext(), tid);
for (TabletMetadata tablet : tablets) {
total++;
- // TODO change all logging to trace
-
if (tablet.getCompacted().contains(tid)) {
// this tablet is already considered done
- log.debug("{} compaction for {} is complete",
FateTxId.formatTid(tid),
+ log.trace("{} compaction for {} is complete",
FateTxId.formatTid(tid),
Review Comment:
done in b573f09
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
