dlmarion commented on code in PR #3955:
URL: https://github.com/apache/accumulo/pull/3955#discussion_r1396342341
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionId.java:
##########
@@ -67,4 +67,10 @@ public static ExternalCompactionId from(String ecid) {
return of(ecid);
}
+ public String encodeForFileName() {
+ // A colon in the file name causes issues in HDFS. Use a different
character
+ // that will not be URLEncoded
+ return canonical().replace(':', '-');
Review Comment:
We could that. We just need to use something that will work in Hadoop
filenames *and* won't be changed during URLEncoding. For some reason URL
encoding was happening twice, which led to issues. Changing the `:` to a `-` in
the ECID Prefix should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
