keith-turner commented on code in PR #3926:
URL: https://github.com/apache/accumulo/pull/3926#discussion_r1399917467
##########
server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java:
##########
@@ -177,45 +175,11 @@ private static KeyExtent fixSplit(ServerContext context,
TableId tableId, Text m
}
}
- /**
- * Update the last location if the location mode is "assignment". This will
delete the previous
- * last location if needed and set the new last location
- *
- * @param context The server context
- * @param tabletMutator The mutator being built
- * @param location The new location
- * @param lastLocation The previous last location, which may be null
- */
- public static void updateLastForAssignmentMode(ClientContext context,
- Ample.TabletUpdates<?> tabletMutator, TServerInstance location, Location
lastLocation) {
+ public static void updateLastLocation(Ample.TabletUpdates<?> tabletMutator,
Review Comment:
This ManagerMetadataUtil code is only used by old tablet server split
recovery code that needs to be migrated to upgrade code eventually. It would
be nice to move this static method to AbstractTabletStateStore as that is the
only thing that uses (except for unit test which could be renamed).
Could also inline updateLocation into this method as this method is the only
thing that calls it.
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1645,7 +1645,10 @@ void
getAssignments(SortedMap<TServerInstance,TabletServerStatus> currentStatus,
AssignmentParamsImpl params =
AssignmentParamsImpl.fromThrift(currentStatus, currentTServerGroups,
unassigned.entrySet().stream().collect(HashMap::new,
- (m, e) -> m.put(e.getKey(), e.getValue().getServerInstance()),
Map::putAll),
Review Comment:
Was this an existing NPE bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
