dlmarion commented on code in PR #3262:
URL: https://github.com/apache/accumulo/pull/3262#discussion_r1402635111
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -317,6 +317,8 @@ public enum Property {
"Properties in this category affect the behavior of the manager
server.", "2.1.0"),
MANAGER_CLIENTPORT("manager.port.client", "9999", PropertyType.PORT,
"The port used for handling client connections on the manager.",
"1.3.5"),
+ MANAGER_PORTSEARCH("manager.port.search", "false", PropertyType.BOOLEAN,
+ "If the manager.port.client is in use, search higher ports until one is
available.", "3.1.0"),
Review Comment:
Need to change version 4.0.0
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -371,6 +373,19 @@ public enum Property {
"Allow tablets for the " + MetadataTable.NAME
+ " table to be suspended via table.suspend.duration.",
"1.8.0"),
+
MANAGER_STARTUP_MANAGER_AVAIL_MIN_COUNT("manager.startup.manager.avail.min.count",
"0",
+ PropertyType.COUNT,
+ "Minimum number of managers that need to be registered before a manager
will start. A value "
+ + "greater than 0 is useful when multiple managers are supposed to
be running on startup. "
+ + "When set to 0 or less, no blocking occurs. Default is 0
(disabled).",
+ "3.1.0"),
+
MANAGER_STARTUP_MANAGER_AVAIL_MAX_WAIT("manager.startup.manager.avail.max.wait",
"0",
+ PropertyType.TIMEDURATION,
+ "Maximum time manager will wait for manager available threshold "
+ + "to be reached before continuing. When set to 0 or less, will
block "
+ + "indefinitely. Default is 0 to block indefinitely. Only valid when
manager available "
+ + "threshold is set greater than 1.",
+ "3.1.0"),
Review Comment:
Need to change version 4.0.0
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java:
##########
@@ -420,11 +420,11 @@ private HostAndPort startServer(AccumuloConfiguration
conf, String address, TPro
private HostAndPort getManagerAddress() {
try {
- List<String> locations = getContext().getManagerLocations();
- if (locations.isEmpty()) {
+ String location = getContext().getPrimaryManagerLocation();
Review Comment:
Should this be any Manager?
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java:
##########
@@ -56,6 +60,12 @@ public DataLevel getLevel() {
return level;
}
+ @Override
+ @Deprecated
+ public void overrideRanges(List<Range> ranges) {
+ this.ranges = ranges;
+ }
+
Review Comment:
This change can be removed.
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -371,6 +373,19 @@ public enum Property {
"Allow tablets for the " + MetadataTable.NAME
+ " table to be suspended via table.suspend.duration.",
"1.8.0"),
+
MANAGER_STARTUP_MANAGER_AVAIL_MIN_COUNT("manager.startup.manager.avail.min.count",
"0",
+ PropertyType.COUNT,
+ "Minimum number of managers that need to be registered before a manager
will start. A value "
+ + "greater than 0 is useful when multiple managers are supposed to
be running on startup. "
+ + "When set to 0 or less, no blocking occurs. Default is 0
(disabled).",
+ "3.1.0"),
Review Comment:
Need to change version 4.0.0
##########
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooUtil.java:
##########
@@ -72,7 +72,11 @@ public LockID(String root, String serializedLID) {
if (lastSlash == 0) {
path = root;
} else {
- path = root + "/" + sa[0].substring(0, lastSlash);
+ path = root;
+ if (!sa[0].startsWith("/")) {
+ path += "/";
+ }
Review Comment:
I had to add this because for some reason `sa[0]` starts with a `/` for the
MANAGERS locks.
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/LoggingTabletStateStore.java:
##########
@@ -60,6 +60,12 @@ public ClosableIterator<TabletManagement>
iterator(List<Range> ranges,
return wrapped.iterator(ranges, parameters);
}
+ @Override
+ @Deprecated
+ public void overrideRanges(List<Range> ranges) {
+ wrapped.overrideRanges(ranges);
+ }
+
Review Comment:
This change can be removed.
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletStateStore.java:
##########
@@ -59,7 +59,20 @@ ClosableIterator<TabletManagement> iterator(List<Range>
ranges,
* Scan the information about all tablets covered by this store..
*/
default ClosableIterator<TabletManagement>
iterator(TabletManagementParameters parameters) {
- return iterator(List.of(MetadataSchema.TabletsSection.getRange()),
parameters);
+ List<Range> ranges = List.of(MetadataSchema.TabletsSection.getRange());
+ if (parameters.getRangeOverrides() != null) {
+ ranges = parameters.getRangeOverrides();
+ }
+ return iterator(ranges, parameters);
+ }
+
+ /**
+ * Override the range of tablets that the TabletStateStore should retrieve.
By default it
+ * retrieves all tablets.
+ */
+ @Deprecated
+ default void overrideRanges(List<Range> ranges) {
Review Comment:
This method can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
