ctubbsii commented on issue #4040: URL: https://github.com/apache/accumulo/issues/4040#issuecomment-1845992228
Oh, actually, I just checked and it looks like `-f` and `-fv` commands are "execute at startup". So, tab-completion should still be enabled, because it goes to the command prompt once the script is done executing unless "exit" is called. So, I think we don't need to do anything for those. It's just up to the user to specify `--disable-tab-completion` explicitly when executing the script and exiting. We should still make sure it's disabled for the `-e` case, though. I was also thinking, it might be better to just deprecate `-e`, since: ```sh $ACCUMULO_HOME/bin/accumulo shell -e "tables" ``` is equivalent to: ```sh $ACCUMULO_HOME/bin/accumulo shell -f <(echo -e "tables\nexit") ``` If anything, rather than have an "execute single command" option, it'd be better to have a command that executes a script and exits automatically, and implies disabling tab completion. But, backwards compatibility must be considered for any such changes. For now, for this issue, it's sufficient to just ensure `--disable-tab-completion` is implied when `-e` is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
