EdColeman commented on code in PR #4071:
URL: https://github.com/apache/accumulo/pull/4071#discussion_r1426062652
##########
core/src/test/java/org/apache/accumulo/core/tabletserver/log/LogEntryTest.java:
##########
@@ -55,17 +55,15 @@ public void test() throws Exception {
assertEquals(validFilename, one.getFilePath());
assertEquals(new Text("-/" + validFilename), one.getColumnQualifier());
assertEquals(validUUID.toString(), one.getUniqueID());
- assertEquals(new Value(validFilename), one.getValue());
// test from metadata entry
LogEntry two = LogEntry.fromMetaWalEntry(new
AbstractMap.SimpleImmutableEntry<>(
- new Key(new Text("1<"), new Text("log"), one.getColumnQualifier()),
one.getValue()));
+ new Key(new Text("1<"), new Text("log"), one.getColumnQualifier()),
new Value("unused")));
Review Comment:
Is using one.getColumnQualifier() the best way to validate the expected
value? Seems rather self-referential rather than testing for a "known" value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
