ctubbsii opened a new pull request, #4082: URL: https://github.com/apache/accumulo/pull/4082
* Use LogEntry type in more places where just the logEntry's filename as a String was being used * Keep the UUID and HostAndPort in LogEntry that are created for validation, rather than their String equivalents * Remove no longer needed deleteWal(String) and create a deleteFromMutation method on LogEntry to keep the schema serialization/deserialization in LogEntry (may want to move that to LogColumnFamily class in the MetadataSchema later, but for now, at least it's in one place) * Use private constructor in LogEntry, do validation in a fromFilePath static method before calling the constructor with the strongly typed results * Update javadocs to clarify the filename format * Fix the validation of the host+port in the filename (it's a plus sign not a colon, because colons weren't valid characters in HDFS, so we used a plus instead) * Simplify VolumeUtil switchVolumes logic that was previously complicated because an old LogEntry format could contain multiple paths per entry and that's no longer the case * Clean up DfsLogger a little bit to remove some old stuff that wasn't needed: remove ServerResources used for testing when a mock ServerContext would suffice, pass LogEntry instead of Strings for the filename and its metadata format (the meta reference being passed wasn't actually what was in the table anyway, it was coming from LogEntry, which was computing it, and Ample wasn't using this meta for deletions/cleanup anyway - may be an existing bug; if so, that will be a follow-on), stop using toString() to compute serialization and remove the redundant use of the logger name itself to try to compute the serialization in that toString() method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
