ddanielr commented on code in PR #4083:
URL: https://github.com/apache/accumulo/pull/4083#discussion_r1430753203
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -53,12 +53,40 @@ public enum Property {
+ "A new external compaction service would be defined like the
following:\n"
+ "`compaction.service.newService.planner="
+
"\"org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner\".`\n"
- + "`compaction.service.newService.opts.queues=\""
+ + "`compaction.service.newService.opts.groups=\""
+ "[{\"name\": \"small\", \"maxSize\":\"32M\"},"
+ "{ \"name\":\"medium\",
\"maxSize\":\"512M\"},{\"name\":\"large\"}]`\n"
+ "`compaction.service.newService.opts.maxOpen=50`.\n"
+ "Additional options can be defined using the
`compaction.service.<service>.opts.<option>` property.",
"3.1.0"),
+ COMPACTION_SERVICE_ROOT_PLANNER(COMPACTION_SERVICE_PREFIX + "root.planner",
Review Comment:
Yes, I wanted to keep this PR smaller and focus on the compaction code logic
changing.
Then modify the property default values in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
