dlmarion commented on issue #4076:
URL: https://github.com/apache/accumulo/issues/4076#issuecomment-1862671585

   > > So, it's likely the case then that we will need to allow users to 
specify additional tags at server startup to emit with the metrics.
   > 
   > That seems generally useful. Were you thinking that all metrics emitted by 
an accumulo process would have these user specified tags appended? How are you 
thinking user would specify these tags?
   
   I was thinkng of a new property, `general.micrometer.tags.additional` or 
something, that defaults to an empty string and is a user-supplied list of 
comma-separated `tag=value` pairs. For example:
   
   ```
   general.micrometer.tags.additional:pod.name=blah;other.tag=foo
   ```
   
   When the set of common tags is 
[initialized](https://github.com/apache/accumulo/blob/elasticity/core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java#L82-L95)
 for the process, we could just read the property there and add the tags.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to