EdColeman commented on code in PR #4077: URL: https://github.com/apache/accumulo/pull/4077#discussion_r1431819157
########## core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperations.java: ########## @@ -202,9 +203,9 @@ default Iterable<Entry<String,String>> getProperties(String namespace) } /** - * Gets a merged view of the properties of a namespace, which are inherited by tables in this - * namespace. Note that recently changed properties may not be available immediately. This new - * method returns a Map instead of an Iterable. + * Gets a merged view of the properties of a namespace from its parent configuration. These + * properties are inherited by tables in this namespace. Note that recently changed properties may + * not be available immediately. This new method returns a Map instead of an Iterable. Review Comment: I don't feel that the `This new method...` lines should be included. They would only be valid for one version, until the are no longer "new". IDE's will highlight the return type when someone tries to use it. Feel free to ignore if it does seem useful and I'm missing that context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
