ctubbsii commented on code in PR #4092:
URL: https://github.com/apache/accumulo/pull/4092#discussion_r1432092437
##########
core/src/main/java/org/apache/accumulo/core/spi/compaction/DefaultCompactionPlanner.java:
##########
@@ -225,6 +225,10 @@ private void determineMaxFilesToCompact(InitParameters
params) {
}
}
+ public int getMaxFilesToCompact() {
+ return this.maxFilesToCompact;
+ }
Review Comment:
Is this SPI addition necessary to implement the bug fix? It would good to
try to avoid the change in a user-facing component in a bug fix release. We can
be looser about it with SPI rather than public API, if necessary, but if it's
not necessary, it'd be good to keep it the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
