ctubbsii commented on code in PR #4085:
URL: https://github.com/apache/accumulo/pull/4085#discussion_r1433515575
##########
server/manager/src/main/java/org/apache/accumulo/manager/recovery/RecoveryManager.java:
##########
@@ -156,72 +156,68 @@ private boolean exists(final Path path) throws
IOException {
}
}
- public boolean recoverLogs(KeyExtent extent, Collection<Collection<String>>
walogs)
- throws IOException {
+ public boolean recoverLogs(KeyExtent extent, Collection<LogEntry> walogs)
throws IOException {
boolean recoveryNeeded = false;
- for (Collection<String> logs : walogs) {
- for (String walog : logs) {
-
- Path switchedWalog = VolumeUtil.switchVolume(new Path(walog),
FileType.WAL,
Review Comment:
It didn't. There just happened to already be an overloaded version of this
method that was for logs, so I called that to reduce the boilerplate.
FileType.WAL is still used inside the overloaded method. The only other thing
inside the overloaded method is some extra trace logging, which I didn't mind
picking up if I could reduce some boilerplate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
