ddanielr commented on code in PR #4092:
URL: https://github.com/apache/accumulo/pull/4092#discussion_r1434715429
##########
core/src/test/java/org/apache/accumulo/core/spi/compaction/DefaultCompactionPlannerTest.java:
##########
@@ -152,12 +171,126 @@ public void testRunningCompaction() {
// planner should compact.
var job = getOnlyElement(plan.getJobs());
assertEquals(candidates, job.getFiles());
- assertEquals(CompactionExecutorIdImpl.externalId("medium"),
job.getExecutor());
+ assertEquals(CompactionExecutorIdImpl.internalId(csid, "medium"),
job.getExecutor());
+ }
+
+ /**
+ * Tests that the maxOpen property overrides the deprecated open.max
property with the default
+ * service
+ */
+ @Test
+ @SuppressWarnings("removal")
+ public void testOverrideMaxOpenDefaultService() {
+ // Set old property and use that for max open files.
+ ConfigurationCopy aconf = new ConfigurationCopy(Map.of(),
DefaultConfiguration.getInstance());
+ aconf.set(Property.TSERV_MAJC_THREAD_MAXOPEN.getKey(), "17");
+ ConfigurationImpl config = new ConfigurationImpl(aconf);
+
+ ServiceEnvironment senv = EasyMock.createMock(ServiceEnvironment.class);
+ EasyMock.expect(senv.getConfiguration()).andReturn(config).anyTimes();
+ EasyMock.replay(senv);
+
+ // Use the CompactionServicesConfig to create options based on default
property values
+ var CompactionServices = new CompactionServicesConfig(aconf, log::warn);
Review Comment:
Yeah that's an oversight. I'll fix the var naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
