ctubbsii commented on code in PR #4125:
URL: https://github.com/apache/accumulo/pull/4125#discussion_r1442180658
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/Utils.java:
##########
@@ -166,8 +168,17 @@ private static Lock getLock(ServerContext context,
AbstractId<?> id, long tid,
var fLockPath =
FateLock.path(context.getZooKeeperRoot() + Constants.ZTABLE_LOCKS +
"/" + id.canonical());
FateLock qlock = new FateLock(context.getZooReaderWriter(), fLockPath);
- Lock lock = DistributedReadWriteLock.recoverLock(qlock, lockData);
- if (lock == null) {
+ DistributedLock lock = DistributedReadWriteLock.recoverLock(qlock,
lockData);
+ if (lock != null) {
+
+ // Validate the recovered lock type
+ boolean isWriteLock = lock.getType() == LockType.WRITE;
+ if (writeLock != isWriteLock) {
+ throw new IllegalStateException("Unexpected lock type " +
lock.getType()
+ + " recovered for transaction " + tid + " on object " + id + ".
Expected "
Review Comment:
@rsingh433 please make this change to the branch (including any necessary
imports)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
