keith-turner commented on code in PR #4156:
URL: https://github.com/apache/accumulo/pull/4156#discussion_r1449657621
##########
test/src/main/java/org/apache/accumulo/test/compaction/CompactionPriorityQueueMetricsIT.java:
##########
@@ -97,7 +98,7 @@ public class CompactionPriorityQueueMetricsIT extends
SharedMiniClusterBase {
private String rootPath;
public static final String QUEUE1 = "METRICSQ1";
- public static final String QUEUE1_METRIC_LABEL = "e." +
MetricsUtil.formatString(QUEUE1);
+ public static final String QUEUE1_METRIC_LABEL = QUEUE1;
Review Comment:
@dlmarion and @ddanielr I am uncertain about this change. I understand why
I needed to remove `e.` for this test. However I am not sure why I needed to
remove the call to `MetricsUtil.formatString()`. I determined I needed to
remove that to make the test pass by printing things out, but not sure if this
is the correct thing to do.
Wondering if its an indication of metrics names not being formated as
expected, but not sure. Going to look into this more later. If either of you
know anything about this please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
