keith-turner opened a new pull request, #4163:
URL: https://github.com/apache/accumulo/pull/4163

   Three tables in the "accumulo." namespace were defined as constants in the 
three classes in the code. The change gathers the definitions of these three 
tables into a single enum in the code. The motivation for this change was that 
the new fate code introduced in #4133 needed to know of the all the accumulo 
tables ids.  The way the code was structured if a new accumulo.X table is added 
in the future someone may not realize the fate code needs to know about it.  
This change makes the dependency more apparent in the code.
   
   Existing constants for the metadata and root table name and id were not 
inlined in the commit for two reasons.  First, it would make this commit hard 
to review.  Second, it would make merging main into the elasticity branch more 
difficult (its already tricky).  Inlining these constants can easily be done as 
a stand alone commit later when the elasticity branch is ready to merge into 
main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to