DomGarguilo commented on code in PR #4160:
URL: https://github.com/apache/accumulo/pull/4160#discussion_r1462188738
##########
core/src/main/java/org/apache/accumulo/core/fate/accumulo/AccumuloStore.java:
##########
@@ -70,7 +70,8 @@ public AccumuloStore(ClientContext context) {
public long create() {
long tid = RANDOM.get().nextLong() & 0x7fffffffffffffffL;
-
newMutator(tid).putStatus(TStatus.NEW).putCreateTime(System.currentTimeMillis()).mutate();
+
newMutator(tid).requireStatus().putStatus(TStatus.NEW).putCreateTime(System.currentTimeMillis())
Review Comment:
This is a good idea. I was also thinking about something similar: how we
can't tell which condition attached to a mutation has caused it to fail. It
would be nice to have something like an optional message that could be added to
the ConditionalWriter.Result object so that when the result is returned, we
could know what caused the mutation to fail.
As things are now though, I am not sure how we could trigger a retry, since
there could be several things that cause an exception to be thrown, we don't
know if its this case where we want a retry to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
