keith-turner commented on code in PR #4191:
URL: https://github.com/apache/accumulo/pull/4191#discussion_r1465551854
##########
core/src/main/java/org/apache/accumulo/core/fate/accumulo/AccumuloStore.java:
##########
@@ -82,7 +85,9 @@ protected Stream<FateIdStatus> getTransactions() {
scanner.setRange(new Range());
TxColumnFamily.STATUS_COLUMN.fetch(scanner);
return scanner.stream().onClose(scanner::close).map(e -> {
- return new FateIdStatus(parseTid(e.getKey().getRow().toString())) {
+ FateId fateId =
+ FateId.from("FATE:" + fateInstanceType + ":" +
e.getKey().getRow().toString());
Review Comment:
Could have a `FateId.from(FateInstanceType it, String hexId)` method and do
the following
```suggestion
FateId.from(fateInstanceType, e.getKey().getRow().toString());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
