ctubbsii commented on PR #4122: URL: https://github.com/apache/accumulo/pull/4122#issuecomment-1911183393
> Unsure if a general exclusion for all rfiles, or something more targeted to the file / directory location would be appropiate. Either are fine. I can't imagine we'd ever have a file ending in .rf where we'd want the plugin to add a license header to it, so can probably just exclude them all `**/*.rf` in the parent POM (and remove any more specific .rf exclusions from any child POMs... I know at least one exists in core/pom.xml). > > Another curiosity is that the licence check inserted the ASL into the export distcp.txt file, but it does not seem to matter to the import code. That one should also be excluded. The format of that file should be one file per line, and the comments it added aren't clearly identifiable as a comment, so we should just avoid it. It also doesn't matter, because there's no copyrightable content in that file anyway. It's just a list of files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
