ctubbsii commented on code in PR #4194:
URL: https://github.com/apache/accumulo/pull/4194#discussion_r1467114407
##########
core/src/test/java/org/apache/accumulo/core/tabletserver/log/LogEntryTest.java:
##########
@@ -64,7 +63,7 @@ public void testFromMetadata() {
private void verifyLogEntry(LogEntry logEntry, Text expectedColumnQualifier)
{
assertEquals(validPath, logEntry.toString());
assertEquals(validPath, logEntry.getPath());
- assertEquals(HostAndPort.fromString(validHost.replace('+', ':')),
logEntry.getTServer());
+ assertEquals(AddressUtil.parseAddress(validHost), logEntry.getTServer());
Review Comment:
I think this one might be okay to leave alone... that way the test validates
the conversion is being done. With this change, it merely validates that it's
consistent with AddressUtil... but AddressUtil could be wrongly used, and this
would go undetected. It's probably best to keep the lower-level conversion in
the test, so it's not dependent on the AddressUtil behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
