cshannon commented on PR #4202: URL: https://github.com/apache/accumulo/pull/4202#issuecomment-1912858075
> > I was hoping git would detect the file rename (it did initially) but after adding more changes it no longer detected AccumuloStoreReadWriteIT being renamed to FateStoreIT so it shows up as a delete/create in the diff. > > That would have been nice. Were any changes made to the actual tests? There were some, I refactored the class a bit so it was abstract and uses the helper executor stuff so that the child classes handle the actual creation of the store. But the logic in the 3 tests themselves are basically identical so i was surprised it didn't detect the rename as so much of the file is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
