DomGarguilo commented on code in PR #4192:
URL: https://github.com/apache/accumulo/pull/4192#discussion_r1470229000
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java:
##########
@@ -291,16 +291,40 @@ public int hashCode() {
private final ServerContext context;
private FSDataOutputStream logFile;
private DataOutputStream encryptingLogFile = null;
- private LogEntry logEntry;
+ private final LogEntry logEntry;
private Thread syncThread;
private AtomicLong syncCounter;
private AtomicLong flushCounter;
private final long slowFlushMillis;
private long writes = 0;
- public DfsLogger(ServerContext context, AtomicLong syncCounter, AtomicLong
flushCounter) {
- this(context, null);
+ public static DfsLogger fromCounters(ServerContext context, AtomicLong
syncCounter,
Review Comment:
I'm not sure of the best name for this method but maybe something like
`fromNewLogEntry` might be a good fit too. I am also fine with leaving it as is
so unless someone else has an opinion I think its fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
