EdColeman commented on code in PR #3969:
URL: https://github.com/apache/accumulo/pull/3969#discussion_r1473232040
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1907,9 +1907,10 @@ public Locations locate(String tableName,
Collection<Range> ranges)
if (foundOnDemandTabletInRange.get()) {
throw new AccumuloException(
- "TableOperations.locate() only works with tablets that have a
hosting goal of "
- + TabletHostingGoal.ALWAYS + ". Tablets with other hosting
goals were seen. table:"
- + tableName + " table id:" + tableId);
+ "TableOperations.locate() only works with tablets that have an
availability of "
+ + TabletAvailability.HOSTED
+ + ". Tablets with other availability's were seen. table:" +
tableName
Review Comment:
```suggestion
+ ". Tablets with other availabilities were seen. table:" +
tableName
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -130,9 +130,10 @@ private class LockCheckerSession {
private final HashSet<Pair<String,String>> invalidLocks = new HashSet<>();
private CachedTablet checkLock(CachedTablet tl) {
- // the goal of this class is to minimize calls out to lockChecker under
that assumption that
- // its a resource synchronized among many threads... want to
- // avoid fine grained synchronization when binning lots of mutations or
ranges... remember
+ // the availability of this class is to minimize calls out to
lockChecker under that
Review Comment:
```suggestion
// the goal of this class is to minimize calls out to lockChecker
under that
```
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -433,8 +433,9 @@ interface TabletMutator extends
TabletUpdates<TabletMutator> {
/**
* A tablet operation is a mutually exclusive action that is running against
a tablet. Its very
* important that every conditional mutation specifies requirements about
operations in order to
- * satisfy the mutual exclusion goal. This interface forces those
requirements to specified by
- * making it the only choice available before specifying other tablet
requirements or mutations.
+ * satisfy the mutual exclusion availability. This interface forces those
requirements to
Review Comment:
```suggestion
* satisfy the mutual exclusion goal. This interface forces those
requirements to
```
##########
core/src/main/java/org/apache/accumulo/core/util/Merge.java:
##########
@@ -83,7 +83,7 @@ public Text convert(String value) {
static class Opts extends ClientOpts {
@Parameter(names = {"-t", "--table"}, required = true, description =
"table to use")
String tableName;
- @Parameter(names = {"-s", "--size"}, description = "merge goal size",
+ @Parameter(names = {"-s", "--size"}, description = "merge availability
size",
Review Comment:
```suggestion
@Parameter(names = {"-s", "--size"}, description = "merge goal size",
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientTabletCacheImpl.java:
##########
@@ -130,9 +130,10 @@ private class LockCheckerSession {
private final HashSet<Pair<String,String>> invalidLocks = new HashSet<>();
private CachedTablet checkLock(CachedTablet tl) {
- // the goal of this class is to minimize calls out to lockChecker under
that assumption that
- // its a resource synchronized among many threads... want to
- // avoid fine grained synchronization when binning lots of mutations or
ranges... remember
+ // the availability of this class is to minimize calls out to
lockChecker under that
+ // assumption that
+ // it's a resource synchronized among many threads... want to
Review Comment:
```suggestion
// it is a resource synchronized among many threads... want to
```
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -173,24 +172,24 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
m = new Mutation(metadataRow);
ServerColumnFamily.DIRECTORY_COLUMN.put(m, new Value(tabletDir));
currentRow = metadataRow;
- sawHostingGoal = false;
+ sawTabletAvailability = false;
}
- if (HostingColumnFamily.GOAL_COLUMN.hasColumns(key)) {
- sawHostingGoal = true;
+ if (TabletColumnFamily.AVAILABILITY_COLUMN.hasColumns(key)) {
+ sawTabletAvailability = true;
}
m.put(key.getColumnFamily(), cq, val);
if (endRow == null &&
TabletColumnFamily.PREV_ROW_COLUMN.hasColumns(key)) {
- if (!sawHostingGoal) {
- // add a default hosting goal
- HostingColumnFamily.GOAL_COLUMN.put(m,
- TabletHostingGoalUtil.toValue(TabletHostingGoal.ONDEMAND));
+ if (!sawTabletAvailability) {
+ // add a default tablet availability
+ TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
+
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
}
mbw.addMutation(m);
- break; // its the last column in the last row
+ break; // it's the last column in the last row
Review Comment:
```suggestion
break; // it is the last column in the last row
```
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1919,9 +1920,9 @@ public Locations locate(String tableName,
Collection<Range> ranges)
if (foundOnDemandTabletInRange.get()) {
throw new AccumuloException(
- "TableOperations.locate() only works with tablets that have a
hosting goal of "
- + TabletHostingGoal.ALWAYS
- + ". Tablets with other hosting goals were seen. table:" +
tableName
+ "TableOperations.locate() only works with tablets that have a
tablet availability of "
+ + TabletAvailability.HOSTED
+ + ". Tablets with other availability's were seen. table:" +
tableName
Review Comment:
```suggestion
+ ". Tablets with other availabilities were seen. table:"
+ tableName
```
##########
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java:
##########
@@ -450,7 +450,7 @@ private class DeriverImpl<T> implements Deriver<T> {
}
/**
- * This method was written with the goal of avoiding thread contention and
minimizing
+ * This method was written with the availability of avoiding thread
contention and minimizing
Review Comment:
```suggestion
* This method was written with the goal of avoiding thread contention
and minimizing
```
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/SimpleLoadBalancer.java:
##########
@@ -50,7 +50,7 @@
/**
* A simple tablet balancer that attempts to spread tablets out evenly across
all available tablet
- * servers. The goal is to achieve the same number of tablets on each tablet
server.
+ * servers. The availability is to achieve the same number of tablets on each
tablet server.
Review Comment:
```suggestion
* servers. The goal is to achieve the same number of tablets on each tablet
server.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
