keith-turner commented on PR #4225: URL: https://github.com/apache/accumulo/pull/4225#issuecomment-1927502099
> @keith-turner - I assume you have seen [ClusterServerConfiguration](https://github.com/apache/accumulo/blob/elasticity/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/ClusterServerConfiguration.java) in the elasticity branch? I didn't add it to the public API when I created it, but you could add an interface for it in elasticity, then backport it to main. Yeah I am familiar with that and this conceptually builds on it, but moves from a mutable config model to a model of an immutable config. I had not looked at that specific class recently, looking at it I changed some of the type and method names in this PR and that solved a problem I was having with being able to specify config that did not make sense. Overall, still not sure about some of the names, initially my main focus was exploring this concept of immutable config so have not thought too much about the names and other aspects. Hoping that the model of having an immutable sever config w/ [getters and setters](https://github.com/apache/accumulo/blob/6c65321965c39cd2898c0158958a877a3536773e/minicluster/src/main/java/org/apache/accumulo/cluster/ClusterControl.java#L54-L92) in ClusterControl will allow us to simplify how tests start and stop servers. Also hoping that we can remove most of the methods in ClusterControl related to starting and stoping servers (I added TODOs in this PR about removing them). Currently in elasticity the code will get a reference to the mutable cluster server config, change it, and then call methods on ClusterControl to start/stop servers. Hoping this streamlines that a bit for our ITs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
