keith-turner commented on code in PR #4238:
URL: https://github.com/apache/accumulo/pull/4238#discussion_r1483228839
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -811,6 +811,11 @@ public enum Property {
+ " that begin with 'table.file' can be used here. For example, to
set the compression"
+ " of the sorted recovery files to snappy use
'tserver.wal.sort.file.compress.type=snappy'.",
"2.1.0"),
+ TSERV_FAILED_BULK_COPY_THREADS("tserver.failed.bulk.threads", "2",
PropertyType.COUNT,
Review Comment:
Digging around I found that code that uses this in main is dead code.
Followed the constant Constants.ZBULK_FAILED_COPYQ in 2.1 and main and found
that nothing adds to the queue in main. This queue was used by bulk v1 to copy
failed files. Bulk v2 does not copy failed.
So in main we need to remove Constants.ZBULK_FAILED_COPYQ and any code that
uses it which would include the code in the tserver that uses this new prop.
With the dead code in main being the only thing that would use this prop,
probably do not want to introduce this new prop. May make sense to remove the
dead code in main first so that inform what to do in 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
