cshannon commented on code in PR #4248:
URL: https://github.com/apache/accumulo/pull/4248#discussion_r1484855874
##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -458,10 +458,14 @@ public Exception getException(FateId fateId) {
}
}
+ private boolean isExecutorAlive(){
+ return executor != null && !executor.isTerminated();
+ }
+
/**
* Initiates shutdown of background threads and optionally waits on them.
*/
- public void shutdown(boolean waitForBackgroundThreads) {
+ public void shutdown(long timeout, TimeUnit timeUnit) {
if (keepRunning.compareAndSet(true, false)) {
fatePoolWatcher.shutdown();
if (executor != null) {
Review Comment:
This is unrelated to your PR but something I noticed is executor should
never be null as it's final and created in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
