keith-turner commented on code in PR #4255:
URL: https://github.com/apache/accumulo/pull/4255#discussion_r1486711881


##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -201,14 +201,13 @@ protected void consume() throws IOException {
       actions.clear();
       Exception error = null;
       try {
+        LOG.trace("Evaluating extent: {}", tm);
+        computeTabletManagementActions(tm, actions);

Review Comment:
   When the manager state is SAFE_MODE, want to host the root and metadata 
table. If the metadata table needs log recovery and we do not call 
computeTabletManagementActions then the log recovery will not happen.  Also if 
the root or metadata table need volume replacement and we do not call 
omputeTabletManagementActions then it will not happen. This change fixes those 
problems, but not sure if it introduces new problems.  I did open #4526 about 
evaluating this code overall.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to