keith-turner commented on code in PR #4257:
URL: https://github.com/apache/accumulo/pull/4257#discussion_r1486748115
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -260,11 +260,6 @@ private void computeTabletManagementActions(final
TabletMetadata tm,
reasonsToReturnThisTablet.add(ManagementAction.NEEDS_VOLUME_REPLACEMENT);
}
- if (!reasonsToReturnThisTablet.isEmpty()) {
Review Comment:
I think I suggested this change in some other PR. Its causing multiple
problems. I tried moving it later in the code and that fixed the volume
recovery problem, but it still caused problems with root tablet compaction. So
just completely removed it as it was an optimization based on what happens in
the TGW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
