keith-turner commented on code in PR #4260:
URL: https://github.com/apache/accumulo/pull/4260#discussion_r1488524048


##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/SplitRecovery12to13.java:
##########
@@ -67,37 +58,6 @@ public class SplitRecovery12to13 {
 
   private static final Logger log = 
LoggerFactory.getLogger(SplitRecovery12to13.class);
 
-  public static void addNewTablet(ServerContext context, KeyExtent extent, 
String dirName,

Review Comment:
   The two method that were removed from the class were moved to the 
integration test because it was the only thing using them.  Thought it made it 
more clear that this code was only used by test code.



##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/SplitRecovery12to13.java:
##########
@@ -67,37 +58,6 @@ public class SplitRecovery12to13 {
 
   private static final Logger log = 
LoggerFactory.getLogger(SplitRecovery12to13.class);
 
-  public static void addNewTablet(ServerContext context, KeyExtent extent, 
String dirName,

Review Comment:
   The two methods that were removed from this class were moved to the 
integration test because it was the only thing using them.  Thought it made it 
more clear that this code was only used by test code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to