DomGarguilo commented on code in PR #4242:
URL: https://github.com/apache/accumulo/pull/4242#discussion_r1489710946
##########
core/src/main/java/org/apache/accumulo/core/fate/accumulo/AccumuloStore.java:
##########
@@ -259,7 +259,8 @@ public void push(Repo<T> repo) throws
StackOverflowException {
throw new StackOverflowException("Repo stack size too large");
}
- FateMutator<T> fateMutator = newMutator(fateId);
+ FateMutator<T> fateMutator =
+ newMutator(fateId).requireStatus(TStatus.IN_PROGRESS, TStatus.NEW);
Review Comment:
Unlike setting the status to make sure the checks pass for the other
operations (pop and delete), removing `NEW` from this part of the code cause an
error in the table create operation:
```
org.apache.accumulo.core.client.AccumuloException: Internal error processing
executeFateOperation
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:437)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:387)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.doTableFateOperation(TableOperationsImpl.java:1737)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:275)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:245)
at
org.apache.accumulo.test.fate.accumulo.AccumuloStoreFateIT.executeTest(AccumuloStoreFateIT.java:45)
at
org.apache.accumulo.test.fate.accumulo.FateStoreIT.testDeferredOverflow(FateStoreIT.java:149)
at java.base/java.lang.reflect.Method.invoke(Method.java:577)
at
java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: org.apache.thrift.TApplicationException: Internal error
processing executeFateOperation
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:81)
at
org.apache.accumulo.core.manager.thrift.FateService$Client.recv_executeFateOperation(FateService.java:135)
at
org.apache.accumulo.core.manager.thrift.FateService$Client.executeFateOperation(FateService.java:116)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.executeFateOperation(TableOperationsImpl.java:312)
at
org.apache.accumulo.core.clientImpl.TableOperationsImpl.doFateOperation(TableOperationsImpl.java:400)
... 12 more
```
I am not too sure why this is happening yet, still looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
