EdColeman commented on PR #4269: URL: https://github.com/apache/accumulo/pull/4269#issuecomment-1947330081
It looks like DistributedWorkQueue (DWQ) was intended as a general utility that was not tied specifically to log recovery. In 2.1.3 it looks like besides log recovery it was used in replication and bulk import v1. Those will have been removed in elasticity, but that does not change the intent DWQ being a general utility that can be used elsewhere again. Tying the implementation to a specific property (GENERAL_RECOVERY_WALOG_SORT_INTERVAL) does not seem the way to go. Even if the property was renamed, it would impact everything using a DWQ, and may be hard to know for a user. (I set the WAL sort time to XX and now Foo seems to be shorter / longer too) Maybe one of these alternatives: a) Create a class that extends DWQ that is used explicitly for log sorting and then use the property in that class and pass it down into DWQ. (The current 1 min could remain the default in DWQ) b) extend the test time for a period to allow for the one minute delay. RecoveryIT is not a sunny test and as long a test can run in parallel, the overall time for a full set of ITs may not change much with this test running longer. In general, it does not seem desirable to add a general, user settable property to support one test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
