keith-turner opened a new issue, #4276:
URL: https://github.com/apache/accumulo/issues/4276

   Fate operations can obtain distributed read/write table locks by calling 
[this 
code](https://github.com/apache/accumulo/blob/da7b3b005e13276c202b4f337496f9ecf2c039e5/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/compact/CompactRange.java#L77).
 A boolean is used to specify the lock type.  Replacing the boolean with an 
enum would have the following advantages.
   
    1. Makes the code more readable
    2. Makes it easy to find all code using a write lock or find all code using 
a read lock.  Can not search on `true` or `false` in the code to find uses 
read/write locks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to