dlmarion commented on code in PR #4285:
URL: https://github.com/apache/accumulo/pull/4285#discussion_r1497451550
##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -623,34 +612,43 @@ public void requestTabletHosting(TInfo tinfo,
TCredentials credentials, String t
manager.mustBeOnline(tableId);
final List<KeyExtent> success = new ArrayList<>();
- final Ample ample = manager.getContext().getAmple();
- try (var mutator = ample.conditionallyMutateTablets()) {
- extents.forEach(e -> {
- log.info("Tablet hosting requested for: {} ", KeyExtent.fromThrift(e));
- KeyExtent ke = KeyExtent.fromThrift(e);
- if (recentHostingRequest.getIfPresent(ke) == null) {
- mutator.mutateTablet(ke).requireAbsentOperation()
-
.requireTabletAvailability(TabletAvailability.ONDEMAND).requireAbsentLocation()
-
.setHostingRequested().submit(TabletMetadata::getHostingRequested);
- } else {
- log.trace("Ignoring hosting request because it was recently
requested {}", ke);
- }
+ final List<KeyExtent> inProgress = new ArrayList<>();
+ extents.forEach(e -> {
+ log.info("Tablet hosting requested for: {} ", KeyExtent.fromThrift(e));
Review Comment:
Suggest moving this log statement down a few lines to where the KeyExtent is
added to `inProgress` - basically when it's been added to
`hostingRequestInProgress` and doesn't already exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
