keith-turner commented on code in PR #4325:
URL: https://github.com/apache/accumulo/pull/4325#discussion_r1508281906
##########
core/src/main/java/org/apache/accumulo/core/data/AbstractId.java:
##########
@@ -32,7 +32,7 @@ public abstract class AbstractId<T extends AbstractId<T>>
implements Comparable<
private final String canonical;
protected AbstractId(final String canonical) {
- this.canonical = Objects.requireNonNull(canonical, "canonical cannot be
null");
+ this.canonical = Objects.requireNonNull(canonical, "canonical cannot be
null").intern();
Review Comment:
Would not want to add `intern()` call here as it would impact all id types,
like the Fate and Compaction id that are very high cardinality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
